C++ Finding largest Number

hk3008 · Feb 20, 2012

ok so I am way confused I am debugging this one and it tells me

1>------ Build started: Project: Double High output, Configuration: Debug Win32 ------
1>Build started 2/20/2012 1:27:46 AM.
1>InitializeBuildStatus:
1> Touching "Debug\Double High output.unsuccessfulbuild".
1>ClCompile:
1> Output Double High.cpp
1>c:\users\hk3008\documents\visual studio 2010\projects\double high output\double high output\output double high.cpp(4): error C2447: '{' : missing function header (old-style formal list?)
1>
1>Build FAILED.
1>
1>Time Elapsed 00:00:00.26
========== Build: 0 succeeded, 1 failed, 0 up-to-date, 0 skipped ==========

and my code is

#include <iostream>
#include <cmath>
using namespace std;
{
int main()
{
//Enter Variables
cout << "Enter Variable a ";
cin >> a;
cout << "Enter Variable b";
cin >> b;
cout >> "Enter Variable c";
cin >> c;
}
{double num(double a, double b, double c)

if (a > b && a > c);
return a;
if (b > a && b > c);
return b;
return c;
}
}
what am I missing it seems simple and I think I have my algorithm right but it hates me

hk3008 · Feb 20, 2012

and I guess I shoudl include the funtion of it is supposed to be a function that accepts three doubles as parameters and returns the largest am I even on the right track?

randomizer · Feb 20, 2012

You seem to have a lot of braces there. The outermost braces are neither for a namespace nor a class, so I'm not sure why they are there. You also don't have an opening brace for the function num(), although there's a brace right before it on the same line, which shouldn't be there. Here is a better formatted version with the braces in the right spots:

Code:

#include <iostream>
#include <cmath>
using namespace std;

double num(double a, double b, double c)
{
    if (a > b && a > c);
        return a;
    if (b > a && b > c);
        return b;
    return c;
}

int main()
{
    //Enter Variables
    cout << "Enter Variable a ";
    cin >> a;
    cout << "Enter Variable b";
    cin >> b;
    cout >> "Enter Variable c";
    cin >> c;
}

Also, note that your num() function is never used. This program will simply get input for 3 variables and then exit.

I am assuming this is from a textbook, but try to avoid using variable names that have no meaning. It might be fine for a 15 line application, but when you get to 1500 lines you'll get lost if all you have are a's, b's and c's

Oh, and comments are bad. Bad bad bad!

hk3008 · Feb 20, 2012

lol thankyou very much my professor was trying to get us to comment more I think I cant remember lol anyways I will highlite the changes and look at what I need to start doing thank you very much it has been a challanging learning process

p.s. parts are from a text book and parts online lol I have been comparing peoples programs and taking what Ithink works and trying to recreate it to my liking lol even though I am not shure whats to my liking yet seeings how it doesnt allways work but experience is a learning process

hk3008 · Feb 20, 2012

Best answer selected by hk3008.

hk3008 · Feb 20, 2012

as well I tried to debug it with the changes

no luck

this is what it said

1>------ Build started: Project: Double High output, Configuration: Debug Win32 ------
1>Build started 2/20/2012 2:41:24 AM.
1>InitializeBuildStatus:
1> Touching "Debug\Double High output.unsuccessfulbuild".
1>ClCompile:
1> Output Double High.cpp
1>c:\users\hk3008\documents\visual studio 2010\projects\double high output\double high output\output double high.cpp(8): warning C4390: ';' : empty controlled statement found; is this the intent?
1>c:\users\hk3008\documents\visual studio 2010\projects\double high output\double high output\output double high.cpp(10): warning C4390: ';' : empty controlled statement found; is this the intent?
1>c:\users\hk3008\documents\visual studio 2010\projects\double high output\double high output\output double high.cpp(18): error C2065: 'a' : undeclared identifier
1>c:\users\hk3008\documents\visual studio 2010\projects\double high output\double high output\output double high.cpp(20): error C2065: 'b' : undeclared identifier
1>c:\users\hk3008\documents\visual studio 2010\projects\double high output\double high output\output double high.cpp(21): error C2784: 'std::basic_istream<_Elem,_Traits> &std:

perator >>(std::basic_istream<_Elem,_Traits> &&,_Ty &)' : could not deduce template argument for 'std::basic_istream<_Elem,_Traits> &&' from 'std:

stream'
1> c:\program files\microsoft visual studio 10.0\vc\include\istream(1128) : see declaration of 'std:

perator >>'
1>c:\users\hk3008\documents\visual studio 2010\projects\double high output\double high output\output double high.cpp(21): error C2784: 'std::basic_istream<_Elem,_Traits> &std: